fun_with_flags icon indicating copy to clipboard operation
fun_with_flags copied to clipboard
verified publisher icon tompave

Update option A documentation with needed changes to releases section

Open zaid opened this issue 3 years ago • 3 comments

Update the Application Start Behaviour section in the README with the needed changes to the releases configuration when choosing Option A.

Resolves #133

zaid avatar Jul 28 '22 01:07 zaid

Thank you for this!

@tompave my pleasure, thank you for your great work on this library!

A couple of questions:

  1. Adding the releases: [ ... ] key to the project(): is it required for both runtime: false and app: false options? It's not clear.

Great question, I just checked and it seems that this is needed for app: false as well so I'll update the PR with the needed changes.

  1. Is this not required at all with Option B?

I just checked and it looks like Option B doesn't require these changes.

zaid avatar Aug 02 '22 21:08 zaid

Awesome, thank you.

When you amend the PR, can you please specify that this is only required when using releases? i.e. not necessary if running with Mix?

tompave avatar Aug 02 '22 21:08 tompave

When you amend the PR, can you please specify that this is only required when using releases? i.e. not necessary if running with Mix?

@tompave sure thing, I just updated the PR with the needed changes. Please let me know if I need to tweak this further.

zaid avatar Aug 02 '22 21:08 zaid

It would be helpful to note that this is also needed for fun_with_flags_ui if that is being used, especially since that README references this one.

nathanalderson avatar Aug 09 '22 14:08 nathanalderson

Thank you for this work! @nathanalderson I think that's fine. At the end of the section the Readme mentions that FWF.UI also needs to be configured differently.

tompave avatar Aug 12 '22 09:08 tompave