Tommaso Pavese

Hi @Gladear , thank you for iterating on this. I'd ask to please not `commit --amend` and force push. It blows away the PR history, and it makes it difficult...

Ok, I think this works in theory, thank you. However, I don't think that the error from https://github.com/tompave/fun_with_flags_ui/issues/26 comes only from the `delete "/flags/:name/boolean"` endpoint you've modified. As I mentioned...

Hey there, thank you for using the package and for reporting this. How many BEAM notes are you running? I wonder to what extent this could be caused by the...

I see. Then that happens because your `GET /flags/:flag_name` request lands on a BEAM node that hasn't loaded that flag in memory yet. The earliest that can happen is by...

It's still not a great solution though. Even if just a few nodes, refreshing `GET /flags` won't guarantee that you hit all nodes. And as the number of nodes increases,...

Ok, I've just realized that I had already solved this problem ages ago. That flag lookup is wrapped with `if safe_flag_exists?(name)`: https://github.com/tompave/fun_with_flags_ui/blob/caca4f7909e1a7745129a03a3d6d625e549cd4a5/lib/fun_with_flags/ui/utils.ex#L75-L77 Which basically does what I described above: https://github.com/tompave/fun_with_flags_ui/blob/caca4f7909e1a7745129a03a3d6d625e549cd4a5/lib/fun_with_flags/ui/utils.ex#L151-L158...

Your stacktrace: ``` lib/fun_with_flags/ui/router.ex in anonymous fn/3 in FunWithFlags.UI.Router.do_match/4 at line 99 lib/plug/router.ex in anonymous fn/4 in FunWithFlags.UI.Router.dispatch/2 at line 246 ``` Ok, so that's happening on different endpoints, not...

Ok, it might be an effect of the Plug macros. Anyway, I can see what's happening here. The fix would be to make the other endpoints safe the same way...

Hey there, thank you for using the library and the PR. Can you please not force-push? It makes it difficult to review and discuss the change. With the initial diff,...

Hello, thank you for iterating on this. I just wanted to align expectations on the timeline. This week I've been too busy to look at this, and I'll be travelling...