vscode-mermaid-editor icon indicating copy to clipboard operation
vscode-mermaid-editor copied to clipboard

Syntax highlighting doesn't seem to work

Open robcresswell opened this issue 3 years ago • 8 comments

Hello!

First off, thanks for creating this, the preview is excellent and works really well.

However, I'm having some issues with the syntax highlighting. For most of my diagrams, it highlights the opening sequenceDiagram but very little else. Are there any known issues there?

robcresswell avatar Apr 16 '21 08:04 robcresswell

I'm sorry for your inconvenience. The syntax highlight has been in the early stage yet. I'll add more highlights in the near future release. Thank you for your patience.

tomoyukim avatar May 05 '21 12:05 tomoyukim

Ah, thats no problem at all! Would you be open to contributions?

robcresswell avatar May 06 '21 20:05 robcresswell

Yes, I appreciate it if I could have your contribution! Thank you.

tomoyukim avatar May 08 '21 03:05 tomoyukim

It looks like this project already implements mermaid syntax highlighting for markdown: https://github.com/bpruitt-goddard/vscode-mermaid-syntax-highlight

I wonder if it would be easy/possible to reuse the code/logic?

sikri-eic avatar Dec 16 '21 13:12 sikri-eic

hey i've same issue. I'd like to switch to the dedicated extension mentioned above as it covers my case in full, but somehow this extension takes priority. would it be possible to disable the bundled syntax highlighting?

rngtng avatar Jan 22 '22 13:01 rngtng

Made a (bit bold) proposal here: https://github.com/tomoyukim/vscode-mermaid-editor/pull/59

rngtng avatar Jan 22 '22 13:01 rngtng

Thank you for your good proposals. I decided to remove it once. I totally agree with using vscode-mermaid-syntax-highlight. Actually, I tried to use it with this extension before but it didn't work fine at my local. So, I created a PR to resolve it. I guess maybe you'll not find syntax highlighting until it's merged. But I believe it's not worth keeping currently broken syntax highlighting.

tomoyukim avatar Jan 23 '22 02:01 tomoyukim

@tomoyukim thanks for your quick reaction, unfortunately this didn't fix it 100% so I created another PR https://github.com/tomoyukim/vscode-mermaid-editor/pull/60

rngtng avatar Jan 23 '22 08:01 rngtng