multifilter icon indicating copy to clipboard operation
multifilter copied to clipboard

Changes for date-filter. Example included

Open manojsethi opened this issue 8 years ago • 2 comments

Hello Tommy,

Please review the date filter. I have added a demo as well.

Maybe you can do some good jQuery stuff than me. Hope it helps.

Cheers Manoj

manojsethi avatar Sep 13 '16 17:09 manojsethi

While I agree with the change in principle, I'm not going to merge as is. A lot of the diff is whitespace changes which are unnecessary and it feels like this code could be improved. I may end up refactoring the switch to be a case statement for the input which feels like a better way to approach this problem. Feel free to keep using your fork but if I do end up refactoring it and adding a date filter I'll be sure to mention your name in the commit.

tommyp avatar Sep 14 '16 09:09 tommyp

Thanks, looking forward to improved version.

manojsethi avatar Sep 14 '16 09:09 manojsethi