KDEpy icon indicating copy to clipboard operation
KDEpy copied to clipboard

Published 20 hours ago • verified publisher icon tommyod

Updates KDEpy to be Python 2 compatible

Open theodoretliu opened this issue 4 years ago • 4 comments

The current version of the library only supports Python 3. Using some future imports and removing some type annotations, this make the library backwards compatible with Python 2.

theodoretliu avatar Aug 16 '19 20:08 theodoretliu

Thanks a lot @theodoretliu . I'm interested in backwards compatibility in general - but more so to earlier versions of 3 than to Python 2, considering that Python 2 end of life is in a few months. Will look over this :+1:

May I ask if you needed to run in on Python 2 yourself, and if so why?

tommyod avatar Aug 17 '19 04:08 tommyod

I have a few projects that still require Python 2 and your package! But I'm also happy to look at previous Python 3 version compatibility too!

theodoretliu avatar Aug 19 '19 15:08 theodoretliu

I used pyenv to also test on Python versions 3.5.7, 3.6.9, and 3.7.4, which all are not deprecated per https://devguide.python.org/.

When I tested with 3.8.0b3+, there were failures, but they were with the installation of numpy version 1.17.0. It seems like the developers of numpy are not focusing on 3.8 until it's an official release (per https://github.com/numpy/numpy/issues/14260#issuecomment-520641203).

Let me know if there's anything else you would like tested out!

theodoretliu avatar Aug 19 '19 22:08 theodoretliu

Great. Thanks a lot!

Since Python 2 reaches EOL soon, I will not merge this branch. I'd like to leave it open however. If someone needs a Py2 version, they can use the work in this branch :+1:

tommyod avatar Aug 21 '19 05:08 tommyod