tommie

Results 112 comments of tommie

Made some fixes. I remembered that I saw Complement being a Go replacement for SyTest, so I've been hacking on that: * Created an HTTP mock server. * Converted the...

Thanks for the testing! https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite We have a navigation event or a redirect after a navigation event sending us to the callback, depending on provider. Following the link in https://github.com/httpwg/http-extensions/issues/2104:...

The redirect_uri, client_id and others are sent in the POST body: https://github.com/tommie/dendrite/blob/loginsso/clientapi/auth/sso/oauth2.go#L119 More specifically https://developers.google.com/identity/protocols/oauth2/web-server#exchange-authorization-code (I don't really understand why they require the `redirect_uri` there, since it's never returned.) BTW,...

Maybe we should move the testing discussion to https://github.com/matrix-org/dendrite/pull/2492 to keep the noise down on this FR.

I have a similar case where I'm using WebUSB to talk to a device, and being able to show that there is a connection or not would be useful.

[#2492 was killed](https://github.com/matrix-org/dendrite/pull/2492#issuecomment-1337734365), and external contributions have been shelved: > We recently updated our [contributing guidelines](https://github.com/matrix-org/dendrite/blob/main/docs/CONTRIBUTING.md#contribution-types). This PR is being closed because it isn't a feature we want to maintain...

Related: I can't find any `` element in Dropdown at all, unless `editable` is set. This breaks HTML form submission/SSR. I can emulate it with a hidden input, of course,...

@jsoref is anything missing here?

@inteon Thank you. I'll get to the review comments shortly.