tommie
tommie
@samip5 I've summarized our discussion so far in a TODO list in the PR description. I should be able to make some progress before the weekend.
> Please feel free, as this is still fairly low on my list at the moment. I'm hoping to dedicate some time to it next week. @neilalexander What is the...
I'm forking @anandv96's PR and continuing. Since it included a solution to #403, and we need that first, I'll start by splitting and trying to get hat closed first.
No. I'm waiting for a review of PR #2014. So far, no response.
It's not done. This was only a part of it. Using tags sounds like a good idea. The next step is rebasing and creating the next PR from https://github.com/tommie/dendrite/commits/loginsso. @kegsay...
The sad truth is I only use Dendrite for family, so the lack of SSO was solved by hard-coding users and passwords. :) So my intrinsic motivation disappeared after the...
Rebased my branch on main: https://github.com/tommie/dendrite/commit/c9ad7206c83baabf7a63cf1cf37295e865d53cae The only change was that `accountDB` seems to not be leaking into `clientapi/` nowadays. Using exposed UserAPI functions instead. ---- Looking through the code,...
Implemented separate SSO association storage and non-interactive account registration.
The redirect URL is indeed internal. Synapse places it under `/_synapse/client/oidc/callback`, but I just placed it next to the speced `redirect` endpoint: https://github.com/tommie/dendrite/blob/loginsso/clientapi/routing/routing.go#L566 So that would be `/_matrix/client/v3/login/sso/callback` to register...
Looks like the client secret isn't sent when requesting the access token. I'm reworking the OIDC/OAuth2 bits. The code states GitHub is an OpenID Connect provider, which it isn't. It...