vim-fubitive icon indicating copy to clipboard operation
vim-fubitive copied to clipboard

Published 20 hours ago • verified publisher icon tommcdo

Wrong handling of Disk Lable like "D:\" in windows

Open ericsunplus opened this issue 2 years ago • 6 comments

Hi there,

Thanks for the plugin, it works perfectly in Ubuntu. However when I goes into windows, the file path starts with Disk Label like "D:....". It seems fubitive will recognize D: as a git revision. Results in

The path "..." does not exist at revision "D"

ericsunplus avatar Aug 04 '23 11:08 ericsunplus

Is this a problem only with vim-fubitive, or with vim-fugitive?

mark2185 avatar Aug 04 '23 12:08 mark2185

Hi @mark2185 , I tried with github repo with vim-rhubarb. No such issue is there.

ericsunplus avatar Aug 04 '23 13:08 ericsunplus

Alright, could you please give me the steps to try and reproduce it?

mark2185 avatar Aug 04 '23 14:08 mark2185

Hi @mark2185 , I don't find a public bitbucket repo. I am working in a company bitbucket repo. Open any file under it and use GBrowse, it will show a page indicating

The path "..." does not exist at revision "D"

The URL is ending with ?at=D, removing it can show the correct file in repo

ericsunplus avatar Aug 07 '23 02:08 ericsunplus

I guess the PR #34 could fix this behaviour.

Could you please try it out to see if it helps?

mark2185 avatar Aug 07 '23 06:08 mark2185

I am not sure if I doing it right. I cherry pick 7321a38 but it don't help. the ?at=D changes to ?until=D, which is still not solving the "D:\" translate from a disk label to a git revision

ericsunplus avatar Aug 07 '23 08:08 ericsunplus