react-split-pane icon indicating copy to clipboard operation
react-split-pane copied to clipboard

Published 20 hours ago • verified publisher icon tomkp

React 17 support

Open mgreca opened this issue 3 years ago • 21 comments

Currently, the peer dependencies of React are specified to be 16.0.0. Can we support React 17?

"react": "^16.0.0-0"
"react-dom": "^16.0.0-0"

mgreca avatar Mar 18 '21 19:03 mgreca

Looks like there is already a PR here: https://github.com/tomkp/react-split-pane/pull/681

maclockard avatar Mar 22 '21 23:03 maclockard

+1 for merging the PR, plz :)

raptoria avatar Apr 28 '21 19:04 raptoria

Look forward to supporting React17 soon +1 for merging the PR, plz :)

yuchonghua avatar Jun 09 '21 08:06 yuchonghua

+1 for merging this PR Thx!

roelnoort avatar Jun 23 '21 19:06 roelnoort

+1 for merging the PR, plz :)

BobDenar1212 avatar Jul 21 '21 08:07 BobDenar1212

+1 for merging the PR!

andredaniel avatar Jul 23 '21 15:07 andredaniel

+100

repartay avatar Jul 23 '21 18:07 repartay

FWIW this library as it stands does work with react 17, you just get a peer dependency warning that you can ignore (at least with yarn)

maclockard avatar Jul 23 '21 21:07 maclockard

+1

george-thomas-hill avatar Jul 29 '21 03:07 george-thomas-hill

FWIW this library as it stands does work with react 17, you just get a peer dependency warning that you can ignore (at least with yarn)

So far as I know with NPM 7, you can either ignore all warnings or none. It's such a trivial thing to just make a new release with the peer dependencies versions updated.

zachsa avatar Aug 10 '21 11:08 zachsa

@zachsa completely agreed, just trying to help unblock folks.

maclockard avatar Aug 10 '21 18:08 maclockard

+1

ururk avatar Aug 28 '21 00:08 ururk

+1

andrelandgraf avatar Oct 11 '21 20:10 andrelandgraf

@tomkp Any updates?

LuisOsta avatar Nov 09 '21 21:11 LuisOsta

please update for react@17..

Nktech-Official avatar Dec 10 '21 12:12 Nktech-Official

Could you please update for React 17?

jasperoosthoek avatar Dec 27 '21 11:12 jasperoosthoek

@tomkp any update on this?

Campaio avatar Jan 06 '22 20:01 Campaio

I've installed it using the npm install --force command and have been able to successful use it without any issues in development. However, this is not an ideal situation...

jasperoosthoek avatar Jan 06 '22 20:01 jasperoosthoek

+1

neimarkbraga avatar Jan 24 '22 16:01 neimarkbraga

These are the only changes that the pull request #681 includes -

image

So... I just did

npm install react-split-pane --force

I'm using FluentUI components and the splitter bar doesn't show up or work, but it does split the screen. Which I might as well do with css...

    <SplitPane split="vertical" defaultSize={140}>
      <Views neomem={neomem} />
      <Table neomem={neomem} />
    </SplitPane>

YMMV

bburns avatar Feb 18 '22 21:02 bburns

hello, any idea when react 17 will be supported? new version is 17.0.2

PauloSSAragao avatar Mar 27 '22 08:03 PauloSSAragao