Discovery Service - Global Criteria Settings

[marconsilva]

Proposal

To simplify the settings block of each resourceDiscoveryGroup definition, we could have a GlobalCriteria block that could house all settings common to all groups, and this way each group could implement only specific filters particular of said group.

Ex:

resourceDiscoveryGroups:
- name: kubernetes-service-landscape
  type: KubernetesService
- name: application-gateway-landscape
  type: ApplicationGateway 
- name: cdn-landscape
  type: Cdn 
- name: container-registry-landscape
  type: ContainerRegistry 
- name: file-storage-landscape
  type: FileStorage 
- name: key-vault-landscape
  type: KeyVault 
- name: load-balancer-landscape
  type: LoadBalancer 
- name: network-interface-landscape
  type: NetworkInterface 
- name: storage-account-landscape
  type: StorageAccount 
    Criteria: #<-- This would be only specific to this group
        include:
           resourceGroups:
           - promitor-resource-group-3
- name: virtual-machine-scale-set-landscape
  type: VirtualMachineScaleSet 
- name: virtual-network-landscape
  type: VirtualNetwork 

globalCriteria: #<-- This would be the new group
    include:
      subscriptionIds:
       - SUBSCRIPTON-ID-ABC
       - SUBSCRIPTON-ID-GHI
       resourceGroups:
       - promitor-resource-group-1
       - promitor-resource-group-2
       tags:
         app: promitor
         region: europe
       regions:
       - northeurope
       - westeurope

Component

Resource Discovery

Contact Details

madasi@↨microsoft.com

[tomkerkhove]

I'm not sure globalCriteria is the best model for this, but I do agree some deduplication would be nice.