Thomas Nixon

set(AudioContentId) calls getParent().lock()->lookup(id) without checking for nullptr

2

It does check for nullptr before doing this, but it could have been removed in the meantime. This is probably the same for the other types.

There are a few instances of this, causing unnecessary copying.

Speed up build

1

libadm is quite slow to build, which makes it less pleasant to work on than it could be. This issue is here to collect ideas and track progress. Some ideas:...

Ideally it should be possible to report a problem without throwing an exception, and without just printing to stderr. Some alternatives: 1) use some 3rd party logging library which has...

changes to files in test_data are ignored

2

Test data files are copied to the build dir here: https://github.com/ebu/libadm/blob/146670a28a6add571065e6493e9bcc2099c12677/tests/CMakeLists.txt#L23 But this only happens when cmake runs, so if the test data is edited it will be stale when...

In `SpeakerPosition`, `ScreenEdgeLock` is optional, but only contains two elements which are themselves optional; this leads to having two states with the same meaning and xml representation: - A `SpeakerPosition`...