Shard icon indicating copy to clipboard operation
Shard copied to clipboard

Boot Behaviour should use the sleep module

Open tomjn opened this issue 9 years ago • 6 comments

The sleep module allows you to pass in a function and a delay. The boot behaviour should use this, but instead it counts frames manually

tomjn avatar Apr 06 '16 19:04 tomjn

@abma I'm concerned that this change could lead to problems as it will require a change to the C++ portion. If the lua is changed but the C++ portion isn't, then no ai object is created, and so no logic is loaded and the AI would be broken, can you think of a simple solution to keep backwards compatability, perhaps a check in ai.lua that would load boot.lua if tripped?

tomjn avatar Apr 11 '16 15:04 tomjn

i don't understand: you commit into a single repository, so both can be updated at the same time.

how should someone only update the c++ part or the lua part?

abma avatar Apr 11 '16 15:04 abma

Some people fetch the latest lua and update that part, but don't really understand the C++ part, more so Windows people than linux people.

I don't really have any metrics on what version is where, especially since every version of Shard of the last few years shows up as dev, but I know it happens

tomjn avatar Apr 11 '16 15:04 tomjn

Some people fetch the latest lua and update that part, but don't really understand the C++ part, more so Windows people than linux people.

i hope these people recognize the relationship between overwriting files and something breaks...

i wouldn't care about this problem: basicly a real version can be used for now as the spring installer disallows to install over an existing spring installation since some time.

abma avatar Apr 11 '16 16:04 abma

hmmm, those people would be forced to wait until the next engine release to do any meaningful work on the Shard lua though

tomjn avatar Apr 11 '16 16:04 tomjn

no, it should be possible to take shard dll's from dev engine. if this doesn't work, the dev-version of spring must be used.

i don't see the requirement for backwards compatiblity: if its really required: (somehow) create an empty/dummy ai object. but i still think this isn't worth the time/work.

abma avatar Apr 11 '16 16:04 abma