Tomás Capretto
Tomás Capretto
Amazing @tjburch! I'll review it soon
@tjburch I didn't mean to close this. I tried to add some changes to this branch but I broke something :S. I'm trying to fix it.
I just checked it and it's still quite incompatible with how Bambi works. I'm not sure I want to refactor Bambi entirely to make it work with `ModelBuilder`. This issue...
Hi @jt-lab thanks a lot for taking care of this! I _think_ double backticks (``) are not needed anymore since we're using Quarto and not sphinx for the docs. Could...
> one incomplete doc strings (see formula.py l19; is this correct?) yes that is correct :)
Hi @jt-lab, do you think you have time to incorporate my comments? I could do it for you if you want, so we get this merged :)
Yes, I think you can pull the most recent version. Maybe there will be some conflicts. Let me know if you need any help :)
It's definitely possible but not 100% trivial. Bambi does not use `pm.sample_posterior_predictive()` under the hood (maybe we should!). It uses `pm.draw(dist(**kwargs))` and the number of draws we obtain depends on...
> @tomicapretto We implemented a temporary solution which just samples the `posterior` group of the trace object and then pass it to `model.predict`. Do you foresee issues with this? Nope,...
@DanielRobertNicoud I want to check if I understand your problem. Using a training dataset you get draws from a posterior distribution. Then you have, let's say, a test dataset where...