Tom Hughes

Results 921 comments of Tom Hughes

I'm sure people are asking for herds of ponies as well - it doesn't mean we're able to magically deliver them.

Can you rebase this on current master please, to get rid of the merge commits, and also squash any fixup commits into the commit they are fixing.

Given that it winds up with one tiny change, yes, that is perfect. Do we actually use that icon anywhere else at the moment? It seems very bold to me,...

That certainly looks better I think. Maybe on a 45 degree angle as well? That seems to be the most common style. A lot of sites (eg github markdown rendering)...

Thanks - can you just squash that into the previous commit? There's no point in making two separate changes to the sprite.

I wouldn't say it was small myself. I mean it won't need that much code but it will presumably mean dragging in some third party component(s) and hence making a...

Well that's the ultra low tech approach for twitter sure, but I think a more normal approach would be to use one of the gems I'm sure exists that adds...

Probably best to put it in screen-ltr.css and screen-rtl.css although you might want to consider only loading it on those pages that need it rather than loading it site wide.

Well neither of those has been maintained recently - in the case of `shareable` it hasn't been touched for ten years. That in turn speaks to the lack of support...

It does look like `social-share-button` is the main player in the is space but honestly it doesn't actually do that much - basically it provides a set of images and...