Tom Hughes

Results 896 comments of Tom Hughes

Yes I know this works by rendering the whole page and sending the changed part - it's a starting point that does the easy things and which can be improved...

I've updated this to use `turbo_frame_request_id` to limit what is rendered on a turbo navigation.

That comes from #4680 because before that people were passing all sorts of silly values which were causing exceptions and triggering error rate alerts.

They should get sent to whatever callback URL you specified in your oauth requests - there are tests for that I believe.

https://github.com/openstreetmap/openstreetmap-website/blob/master/test/integration/oauth_test.rb#L225 is the test in question.

Right, but they should still end up going through oauthorize at the end right, to authorize the new account?

My point was that when they get to `oauthorize` the callback URL should still work and send them back to your site.

What we really need is the full list of URLs that are visited so that we can tell where the callback is getting list - in theory it should be...

The whole question of client side work vs server side work and how we do things is kind of in flux at the moment so this might not be the...