Take &str instead of String in purs_module!()

Open Boscop opened this issue 7 years ago • 2 comments

It would be more ergonomic:

purs_module!("Data.Dogs"; Dachsund, ChowChow, Mutt<Void, Void>)

PursModule would have an added lifetime <'a> and member name would be &'a str.

Jan 18 '18 04:01 Boscop

This should not be a problem, especially since I think for most use-cases a string literal is going to be used there. I have no objection to this making it into the release (next time I have time to work on this project).

Jan 23 '18 21:01 tomhoule

It could also be done by calling .to_string() in the macro before constructing the PursModule. Then PursModule wouldn't need to track that lifetime.

Jan 24 '18 01:01 Boscop