routemaster icon indicating copy to clipboard operation
routemaster copied to clipboard

Custom path parameters with CupertinoTabPage get replaced with placeholder

Open daanporon opened this issue 2 years ago • 1 comments

I am experimenting with different routers to see if it's a fit for our navigation structure. Routemaster fits very well, it works very intuitively. I'm only experiencing one issue.

/home/product-a/:pid is a route which shows a CupterinoTabPage. :pid is an id, but when i go to for example '/home/product-a/1234/tab-a' by just navigating inside the app i see that 1234 is replaced by the :pid placeholder in the url, so this path parameter is lost.

When i navigate directly to '/home/product-a/1234/tab-a' by refreshing the browser for example you'll see it doesn't recognise the CupterinoTabPage. But when i navigate directly to '/home/product-a/:pid/tab-a' it does work.

Any idea what could go wrong here? I uploaded my code to a gist.

https://user-images.githubusercontent.com/71901/174838644-e6a78fe4-7f36-4960-90cc-ed92dbccbbf8.mov

daanporon avatar Jun 21 '22 15:06 daanporon

Hello, looks like a nasty bug, will investigate.

Thank you so much for the video and gist, very useful

tomgilder avatar Jul 22 '22 09:07 tomgilder