tomer doron

Results 124 comments of tomer doron

yes, lets address the soundness checks violations. re-kicked it so we have a fresh copy

@swift-server-bot test this please

I am +1 to take this. @sebsto thoughts?

could be interesting for sure. do you want to submit a PR?

one thing that could help is to be able to filter out specific loggers. in this case, the issue comes from the websocket library that has this logger setup: ```...

@Lukasa @normanmaurer this came up in my conversations with @weissi regarding the new `ByteToMessageDecoder` and `MessageToByteEncoder` in swift-nio 2 which are a departure from the classic netty handler model. for...

> The way we could most naturally do better would be to provide a default implementation of this other handler that does just close on idle timeout. That will at...

nio's versions are a bit different from the ones in AWSLambdaEvents, the latter are designed for JSON payload decoding/encoding we could consider adding a prefix to more easily disambiguate.

@helje5 IIRC the main issues was that we would need to be extending these types to add functionality to them (Codable conformance mainly IIRC). rule of thumb we have been...

> You don't need to extend the types to decode them (yes, Codable can only be added to the original type itself, but that is not required here). You can...