whatsapp-web-incognito icon indicating copy to clipboard operation
whatsapp-web-incognito copied to clipboard

Added Safari Extention

Open taksh108 opened this issue 2 years ago • 5 comments

Safari extention added. Works for group Chats but not for Individual chats

taksh108 avatar Nov 01 '21 16:11 taksh108

Is there any way to prevent the code duplication? Also do you have an idea of why it doesn't work for individual chats? Do you have a stack trace?

tomer8007 avatar Nov 01 '21 17:11 tomer8007

I actually started learning about making extensions about 24 hours ago, so at this time, I really don't know how to answer your questions. This, and SpotiAds are my first commits to github

taksh108 avatar Nov 01 '21 18:11 taksh108

Also, the feature seems to be working fine on both individual and group chats. I must've not tested correctly previousl Screenshot 2021-11-02 at 1 55 48 AM y

taksh108 avatar Nov 01 '21 20:11 taksh108

This looks good, I think the only problem is the duplication of code files. If you can find a way to not need that and still have the same repo for both Chrome and Safari it'd be great. If not, we can just have a link to your fork for those who want Safari support. The same is true for SpotiAds.

tomer8007 avatar Nov 02 '21 14:11 tomer8007

I have figured out to package It into a single binary so that we only need share only 1 file, but I am not sure if it will work for everyone. It runs on my computer as I built it, but since I am not enrolled in Apple's Paid Developer program, Binaries signed by me might not work for others. Will update once I have researched more. Also, you can check out the directory structure of https://github.com/ajayyy/SponsorBlock as they have all extensions in one repo. Tho the Distribution method is quite different

taksh108 avatar Nov 02 '21 17:11 taksh108