hikari-cp icon indicating copy to clipboard operation
hikari-cp copied to clipboard

Reflection warnings

Open vemv opened this issue 2 years ago • 0 comments

Hi! Nice library, I think I wasn't aware of it (had used raw Hikari a few times).

Giving it an Eastwood pass over it, I noticed it has many reflection warnings:

test/hikari_cp/core_test.clj:3:9: unlimited-use: Unlimited use of (expectations) in hikari-cp.core-test.
test/hikari_cp/core_test.clj:76:14: reflection: reference to field getDataSourceProperties can't be resolved.
test/hikari_cp/core_test.clj:78:9: reflection: reference to field getDataSourceClassName can't be resolved.
test/hikari_cp/core_test.clj:80:3: reflection: reference to field getDataSourceClassName can't be resolved.
test/hikari_cp/core_test.clj:82:9: reflection: reference to field isAutoCommit can't be resolved.
test/hikari_cp/core_test.clj:84:9: reflection: reference to field isReadOnly can't be resolved.
test/hikari_cp/core_test.clj:86:9: reflection: reference to field getConnectionTimeout can't be resolved.
test/hikari_cp/core_test.clj:88:9: reflection: reference to field getValidationTimeout can't be resolved.
test/hikari_cp/core_test.clj:90:9: reflection: reference to field getIdleTimeout can't be resolved.
test/hikari_cp/core_test.clj:92:9: reflection: reference to field getMaxLifetime can't be resolved.
test/hikari_cp/core_test.clj:94:9: reflection: reference to field getMinimumIdle can't be resolved.
test/hikari_cp/core_test.clj:96:9: reflection: reference to field getMaximumPoolSize can't be resolved.
test/hikari_cp/core_test.clj:98:9: reflection: reference to field getDataSourceClassName can't be resolved.
test/hikari_cp/core_test.clj:100:9: reflection: reference to field getUsername can't be resolved.
test/hikari_cp/core_test.clj:102:9: reflection: reference to field getPassword can't be resolved.
test/hikari_cp/core_test.clj:104:9: reflection: reference to field getDataSourceProperties can't be resolved.
test/hikari_cp/core_test.clj:108:9: reflection: reference to field getMetricRegistry can't be resolved.
test/hikari_cp/core_test.clj:110:9: reflection: reference to field getMetricRegistry can't be resolved.
test/hikari_cp/core_test.clj:113:3: reflection: reference to field getHealthCheckRegistry can't be resolved.
test/hikari_cp/core_test.clj:115:3: reflection: reference to field getHealthCheckRegistry can't be resolved.
test/hikari_cp/core_test.clj:118:3: reflection: reference to field getMetricsTrackerFactory can't be resolved.
test/hikari_cp/core_test.clj:120:3: reflection: reference to field getMetricsTrackerFactory can't be resolved.
test/hikari_cp/core_test.clj:123:3: reflection: reference to field getTransactionIsolation can't be resolved.
test/hikari_cp/core_test.clj:126:9: reflection: reference to field isAutoCommit can't be resolved.
test/hikari_cp/core_test.clj:128:9: reflection: reference to field isReadOnly can't be resolved.
test/hikari_cp/core_test.clj:130:9: reflection: reference to field getConnectionTimeout can't be resolved.
test/hikari_cp/core_test.clj:132:9: reflection: reference to field getValidationTimeout can't be resolved.
test/hikari_cp/core_test.clj:134:9: reflection: reference to field getIdleTimeout can't be resolved.
test/hikari_cp/core_test.clj:136:9: reflection: reference to field getMaxLifetime can't be resolved.
test/hikari_cp/core_test.clj:138:9: reflection: reference to field getMinimumIdle can't be resolved.
test/hikari_cp/core_test.clj:140:9: reflection: reference to field getMaximumPoolSize can't be resolved.
test/hikari_cp/core_test.clj:142:9: reflection: reference to field getPoolName can't be resolved.
test/hikari_cp/core_test.clj:144:9: reflection: reference to field getConnectionInitSql can't be resolved.
test/hikari_cp/core_test.clj:146:9: reflection: reference to field getConnectionTestQuery can't be resolved.
test/hikari_cp/core_test.clj:148:9: reflection: reference to field isRegisterMbeans can't be resolved.
test/hikari_cp/core_test.clj:151:11: reflection: reference to field getDriverClassName can't be resolved.
test/hikari_cp/core_test.clj:153:9: reflection: reference to field getJdbcUrl can't be resolved.
test/hikari_cp/core_test.clj:156:9: reflection: reference to field getDataSourceClassName can't be resolved.
test/hikari_cp/core_test.clj:167:9: reflection: reference to field getJdbcUrl can't be resolved.
test/hikari_cp/core_test.clj:232:11: reflection: reference to field getLeakDetectionThreshold can't be resolved.
test/hikari_cp/core_test.clj:238:16: reflection: reference to field getLeakDetectionThreshold can't be resolved.
test/hikari_cp/core_test.clj:248:14: reflection: reference to field getDataSourceProperties can't be resolved.

You might be interested in having them fixed.

Cheers - V

vemv avatar Jun 06 '22 14:06 vemv