Tom Dalziel

Results 125 comments of Tom Dalziel

That's great news, thanks. I'll take a look on the weekend. Agree I'd like @chopptimus to take a look if possible.

Some notes from testing: - You'll need to `(require face-remap)` at the top of evil-commands.el to make sure `text-scale-mode-...` vars are always there when you need them - I agree...

I'm conflicted about this. If you have your cursor on the final paren on this line, which sexp do you want to kill? ``` (+ 1 (* 2 3)) ```...

Just thought about this a little further - I suppose you'd delete the `(* 2 3)` sexp by placing your cursor on the penultimate paren? That makes sense to me....

Sorry for spamming this issue, but I just tried your change, and I feel the behaviour on the penultimate paren is strange. It still deletes the whole line. Is this...

OK I think I need to take a closer look at this. Thanks for your explanations.

OK I've taken another look and can confirm that in normal mode in vanilla emacs with your PR, `backward-kill-sexp` deletes the entire line when on the penultimate paren, and deletes...

Ah I've just tried this in emacs 25 and it behaves like you describe. (I do most of my evil dev in emacs 28 but keep a vm with emacs...

Great detective work @knusprjg! Yes the question of how advice should be handled for a function that calls itself is interesting... May indeed be worth raising with emacs devs. But...

Thanks for the write-up @knusprjg! I'd like to think that most people who work with sexps often would be using lispyville or evil-cleverparens, so I'm not too inclined to put...