Tom Dalziel

Thanks for this! I'm in hols right now but will take a look in a couple of weeks if no one beats me to it.

@Garklein before I take a proper look, will you add some tests? I can if you can't, but it may delay things a little.

Looks good. Two things I noticed: - `di(` doesn't move the cursor, but it should - `vi(` on empty parens only selects the second paren, but it should select both...

@Garklein I put in some fixes. I decided I'm not interested in the edge case of `vi(` on empty parens 🤷 - take a look if you like - I'll...

Oh good spot! Yes please try to take a look - sounds a bit tricky.

Looks great. Thanks both! That's merged to master 🚀

@dalanicolai what do the instructions `open pdf-tools in evil-state` mean? I am not a spacemacs user, so can I have exact instructions to reproduce this with only evil and pdf-tools...

In my emacs, when I open a PDF, it opens with DocView. I do `M-x pdf-tools-view` which gives me the pdf-tools interface. But doesn't put me in `normal-state`. So I...

And do you actually want to be in evil-motion-state in pdf-tools mode?

I noticed they have this binding: https://github.com/emacs-evil/evil-collection/blob/6306aa78a94bc517b77bdecde830802c4ac1d9bd/modes/pdf/evil-collection-pdf.el#L170 in `'pdf-view-mode-map` which may help? I don't use evil-collection either, btw.