holy-loader icon indicating copy to clipboard operation
holy-loader copied to clipboard

bug: Spinner doesn't work

Open Uzzal-Bhowmik opened this issue 1 year ago • 2 comments

Description

Although, showSpinner prop is set to true, the spinner doesn't seem to work for me.

https://github.com/user-attachments/assets/fd03793e-f8f6-46d6-b4ac-2c76ac9acdd2

Reproduction steps

<HolyLoader
      color="linear-gradient(to right, #65b545, #1b71a7)"
      height="3px"
      speed={250}
      easing="linear"
      showSpinner={true}
/>

- This is my code. And here showSpinner doesn't work!

Screenshots

No response

Logs

No response

Browsers

Chrome

OS

No response

Uzzal-Bhowmik avatar Nov 07 '24 11:11 Uzzal-Bhowmik

Thanks for the report, will look into what could be causing this.

tomcru avatar Nov 07 '24 11:11 tomcru

This issue is because the spinner is built with a border & borders do not accept linear-gradient out of the box. I will think about how to work this in. Options are to add a separate color prop for the spinner, rebuilding the spinners css to allow for gradients, or maybe even make a separate spinner component so styling it becomes a lot easier.

tomcru avatar Nov 17 '24 14:11 tomcru