Tom de Bruijn

Results 171 comments of Tom de Bruijn

@shairyar do you need to follow up with the following conversations, or can we close the issue? - https://app.intercom.com/a/apps/yzor8gyw/inbox/inbox/conversation/16410700116700 / https://app.intercom.com/a/apps/yzor8gyw/inbox/inbox/conversation/16410700105480 - https://app.intercom.com/a/apps/yzor8gyw/inbox/inbox/conversation/16410700079256

Add a config option: `revision: abcdef1` Or add a revision file `APP_REVISON`/`.appsignal_revision` with one line that reads the last revision We will keep the `APP_REVISION` env var Also relevant for...

We now have a `revision` config option: https://docs.appsignal.com/ruby/configuration/options.html#option-revision We still should look if there's a way to set it from the capistrano config, which sets it on the deployed servers.

I tried this before and ran into some issues with the test suite, to assert this message is only printed once. My work so far: ```diff diff --git lib/appsignal/config.rb lib/appsignal/config.rb...

Updated the issue description with a TODO list of steps we need to take to support Hanami fully.

Hi @AnshulRiyal, This isn't can't be closed yet. No one is currently working on it. I was thinking of changing the Probes module to a class, then it would work....

@AnshulRiyal you're welcome to send in a PR to fix the issue as described :)

https://app.intercom.io/a/apps/yzor8gyw/inbox/inbox/540709/conversations/22322377398

This has been changed to the `ActionDispatch::DebugExceptions` middleware in #286. Same problem there. If you remove that middleware the same problem occurs.

Timeboxed in an hour: look if we can detect which middleware is present at the time we add our middleware to the proxy. If not, close the issue and this...