Thomas Buckley-Houston
Thomas Buckley-Houston
Thanks! I suppose that's more of a luxury feature? The current algorithm uses UTF8 half blocks (â–€) which are simple and effective and producing pixelated graphics. The trouble with ASCII...
I think that's something that should be taken up with the maintainer of that repo on the AUR. Browsh can already use _any_ version of Firefox that supports the new...
Ah yeah, of course, that definitely be possible, good thinking.
I do know of it! Browsh is actually using https://github.com/gdamore/tcell which is very similar, but native to Golang, so is a native dependency. The TUI isn't actually the biggest issue...
Very interesting, and nice detective work! I'll mark this as a bug then
Thanks for the comments. I've fixed the tests now (at least locally). The only things that need to be done are adding a few comments and fleshing out the tests....
Oh I didn't know that about `init()`! I put it in `TTYStart()` instead then, just so all the init is in one place.
Hmm, that's an interesting bug. I don't see it on my machine. Which makes me think that the only possible difference is that I've recently run `dep ensure` and `npm...
Thanks Jared :) Either is fine. I guess I'd lean towards adding a new folder for those tests.
The biggest thing stopping this being merged is the failing tests. Travis is just hanging so it's hard to debug. I've got some WIP code locally overhauling the test setup...