reports_kit icon indicating copy to clipboard operation
reports_kit copied to clipboard

Published 20 hours ago • verified publisher icon tombenner

Added Support for MS SQL Server

Open darkstego opened this issue 6 years ago • 3 comments

Added adapter for MS SQL SERVER

darkstego avatar Mar 28 '18 22:03 darkstego

@tombenner Are there any plans on merging in this pull request? I would find it useful for a project that I am doing.

cdhagmann avatar Sep 09 '20 20:09 cdhagmann

Sorry for the delay! I'd be happy to accept this, but we'll want to make sure that it's tested. This should be fairly easy/quick to do; appraisals for MS SQL Server can be added to the Appraisals file, similar to the existing ones for Postgres and MySQL, and then the tests can be run using appraisal rspec, as described in the README.

@cdhagmann You may want to open a new PR for this, unless @darkstego wants to add it to this PR.

tombenner avatar Sep 12 '20 15:09 tombenner

I tried looking into this, but unfortunately I get a byebug compilation error whenever I try to run bundler on the project.

darkstego avatar Sep 15 '20 22:09 darkstego