nui icon indicating copy to clipboard operation
nui copied to clipboard

Button render equal setters, different properties.

Open squarefrog opened this issue 11 years ago • 0 comments

In NUIButtonRenderer, padding is set to setTitleEdgeInsets:

    if ([NUISettings hasProperty:@"padding" withClass:className]) {
        [button setTitleEdgeInsets:[NUISettings getEdgeInsets:@"padding" withClass:className]];
    }

https://github.com/squarefrog/nui/blob/master/NUI/Core/Renderers/NUIButtonRenderer.m#L29-L31

The same property is used for title-insets
    if ([NUISettings hasProperty:@"title-insets" withClass:className]) {
        [button setTitleEdgeInsets:[NUISettings getEdgeInsets:@"title-insets" withClass:className]];
    }

https://github.com/squarefrog/nui/blob/master/NUI/Core/Renderers/NUIButtonRenderer.m#L158-L160

Is this intentional?

squarefrog avatar May 29 '14 07:05 squarefrog