Thomas Steiner

Results 462 comments of Thomas Steiner

> The same 8 tests fail on the v7 branch, so they have nothing to do with these changes. Thanks for checking! @tropicadri, over to you for a final look....

If you never touch the toggle, it uses what the system says.

If the toggle doesn't have the [`permanent` attribute](https://github.com/GoogleChromeLabs/dark-mode-toggle#properties), the site will reset to the system default. Let's assume the system preference is light mode. ``: - Toggle dark mode. -...

(It's up to the site owner to choose if they set the `permanent` attribute. Personally, I do on my [blog](https://blog.tomayac.com/).)

I changed my mind and now do think we should have at least an option to have a three-way toggle. Is anyone on this thread happy to work on a...

Functionality-wise, the "system" option would just need to delete the localStorage entry. The actual work would more need to focus on how to expose this UI wise. Some of the...

I have seen sites use a slash icon like [this](https://user-images.githubusercontent.com/56068232/211295175-e9f2cafe-5725-4e2c-903a-d4914580f030.jpg).

This PR is gold and should be merged. Not showing a dynamic `fetch()` is my pet peeve with any autocomplete component.

I have a new local build ready, but fail to get it out to users: ![Screenshot 2023-10-04 at 11 57 55](https://github.com/google/service-worker-detector/assets/145676/34c76d4e-6a24-463b-af01-bb0ef31369aa) If you have experience in this space, I'd appreciate...

Was reminded of this Issue and wondering what to make of it. Do we agree it's somewhat of an interop issue?