Thomas Steiner
Thomas Steiner
Fully approve of the intent of the PR. However, I don't think `Promise.allSettled()` needs polyfilling looking at [browser support](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled#browser_compatibility). Looking at devices that didn't make the Safari 13 cut, this...
> unconditionally requesting permission... This is what the [demo](https://badging-api.glitch.me/#:~:text=It%20also%20requires%20the%20Notifications%20permission%20on%20some%20platforms.) does now unfortunately.
(Signal-boosted [on Twitter](https://twitter.com/ChromiumDev/status/1320671512689549314).)
The comment from @willmorgan at https://github.com/w3c/screen-wake-lock/issues/129#issuecomment-737462720 makes a connection from maximum screen brightness to ALS.
(Bikeshedding, I know.) Wording it as "dusk" is dangerous, though, as dusk is connected to the time between day and night. You don't call temporary darkness in a tunnel "dusk"....
Is anyone still interested in this? The code as is seems to be pretty stable, so maybe we can close this?
> @tomayac, the refactoring is done, it just needs a proper code review. Feel free to close the PR if you do not think this code refactoring is beneficial for...
There's lots of noise because of trailing whitespace. The actual change begins [here](https://github.com/Lexxie9952/fcw.org-server/pull/204/files#diff-476662785abc3c97b01f1537cd2c98f4c04f407640d2fa1d107265f36660ca2dR8260).
Is there any interest in merging this? For background: https://developer.chrome.com/blog/better-full-screen-mode/#in-practice.
@andreasrosdal, great to see this in fciv.net. @Lexxie9952, are you interested in this improvement, too?