dibbler icon indicating copy to clipboard operation
dibbler copied to clipboard

Fix subnet prefix calculation

Open ekacnet opened this issue 2 years ago • 3 comments

Prefix calculation was wrong, and testing was complicated so I fixed it. I was seeing errors like RTNETLINK answers: File exists before because my ISP is delegating a /60 and I'm asking for 3 interfaces to be delegated but in reality the prefixes where the same on the first 64 bits.

ekacnet avatar Apr 29 '22 03:04 ekacnet

Hey, thanks a lot for the PR. Not sure if that's intentional, but you proposed to change close to 100k lines of code. Can you resubmit this PR without editing every single file in Dibbler tree? :)

Seriously, though, I gave up on Dibbler a long time ago. I may merge small stuff like #46 or #47, but I won't do a release.

tomaszmrugalski avatar Mar 25 '23 17:03 tomaszmrugalski

The more I look at this, the more I like it. I need to figure out a way how to merge it, without sending all other branches to conflict hell. Stay tuned.

tomaszmrugalski avatar Mar 25 '23 19:03 tomaszmrugalski

I've processed all the other PRs and rebased other branches that are possibly useful. The next here is to untangle the 05fe17c commit and pick the remaining changes that look good so far.

tomaszmrugalski avatar Mar 26 '23 07:03 tomaszmrugalski