tomaszduda23
tomaszduda23
I adjusted https://github.com/esphome/esphome/pull/11634 to follow `usb_cdc_acm`. There are some esp32 specific implementation which do not allow use this component as it is. It would be great if the implementation could...
@bdraco I would appreciate review if you have a time. I'm working to make nRF52 more usable.
> Probably overkill but have you considered utilizing ["ZAP" (ZCL Advanced Platform)](https://github.com/project-chip/zap) to auto generate/setup clusters data needed? That’s interesting, thank you. We’ve already aligned on basic support between the...
@bdraco If you have some time, I would really appreciate you reviewing this. Together with OTA, it’s one of the last remaining pieces needed to make nrf52 truly useful within...
> Remind me this weekend. It's 🦃 day in the US so I have a house full Hope you had a great holiday! Thanks for the review.
@bdraco did you though about enforcing type checking by CI or typeguard, etc?
> > @bdraco did you though about enforcing type checking by CI or typeguard, etc? > > Thats the plan eventually but we have so much missing typing in the...
all comments were addressed. Thanks for the review.
> Seems you are doing even more on the python side instead of C++ than I do :-D There is not really another option. Some types are defined by macros...
@swoboda1337 compilation error should be fixed.