crawler icon indicating copy to clipboard operation
crawler copied to clipboard

Published 20 hours ago • verified publisher icon tomasnorre

[BUGFIX] Add new middleware for content finish

Open tomasnorre opened this issue 4 years ago • 10 comments

This middleware splits the content from the Crawler Initialization Middleware to ensure that the content is written at the end.

This ensures that middleware that expects response-object gets the content for the renders and the crawler queue gets the correct request status.

Resolves: #729

I have

  • [x] Checked that CGL are followed
  • [x] Checked that the Tests are still working
  • [x] Added description to CHANGELOG.md (github-handle is optional)
  • [ ] Added tests for the new code

tomasnorre avatar Apr 13 '21 18:04 tomasnorre

@CDRO I could not assign you as reviewer, would you mind looking at the PR?

tomasnorre avatar Apr 13 '21 18:04 tomasnorre

@tomasnorre Looks good to me!

CDRO avatar Apr 14 '21 06:04 CDRO

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 21 '21 06:07 stale[bot]

/remove stale

tomasnorre avatar Jul 21 '21 07:07 tomasnorre

Hi @lochmueller,

I was just looking into stalled PRs, could this perhaps be the solution that would also solve the problem the crawler is causing for the Staticfilecache? #837

I would be happy to hear you feedback.

tomasnorre avatar Oct 30 '21 18:10 tomasnorre

Hey @tomasnorre This move "the problem" just up in the middleware stack, so StaticFileCache would work. But it still detroy the middleware stack, because a "new response" is created. I send a new pull request incl. a better solution in a few minutes... Regards, Tim

lochmueller avatar Oct 30 '21 20:10 lochmueller

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 21 '22 17:12 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 26 '23 21:02 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 28 '23 10:04 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 27 '23 17:06 stale[bot]