Tomas Norre Mikkelsen

Results 202 comments of Tomas Norre Mikkelsen

@ulrichmathes If you have a suggested fix in mind, I would be happy to review a PR.

Hi @hacksch, Sorry for not getting back to you. What do you think of the approach in PR https://github.com/tomasnorre/crawler/pull/1091?

Thanks for the information. If you have a PR for this, I would be happy to review it.

The problem is that the code is changed for a reason that I don't recall anymore. We had an issue at some point, and that's why we changed it. I...

I'll close this as the PR from @cweiske, also solves this.

I would go for solutions 3, `Provide ready-made enum`, as it's the "right" way to solve the problem in real life, but the one with `enums` that requires less for...

@cweiske is this solved with https://github.com/tomasnorre/crawler/pull/1167 too?

Closed according to comment https://github.com/tomasnorre/crawler/pull/1091#issuecomment-3248351390

First, thanks a lot for providing the PR. To be honest. I have see this behavior before and tried to change the order of the if-checks, but gave other side...