tomaskallup

Results 34 comments of tomaskallup

@HerringtonDarkholme As far as I know, you cherry picker some commits from this, can this be closed or is this PR waiting for something?

Feel free to submit a PR, I've recently run into this issue.

I tried to take a stab at this on my fork, everything seemed good, but there are some edge cases. For example this breaks the highlight: ```typescript ({ type, size,...

Also `classNameFromProps` in the example above turns into typescriptTypeReference. I'll see if I can improve the regex and fix the aliasing

@HerringtonDarkholme I may need your input on this. I have a pretty well working example but I ran into an issue. My version breaks when there are multiple arguments, eg....

@HerringtonDarkholme I thought member of the region could consume other `(` and `)`. If that's not possible, then I don't really see a way to get around this. Or is...

Oh I see, for stuff like this it's nicer to have the type stored somewhere in a `type` as it makes the code more readable.

My initial thoughts on this are to have multiple sections: ## Allocators Section describing all the current allocators with an example of how to acquire it and brief info of...

The `fixupPluginRules` didn't do the job for us, as we use filenames/match-regex with a parameter. So I ended up wrapping the plugin like so: `file-names-plugin.js` ```js const { fixupRule }...

I've tried it, reindented a couple of files and seems fine from a quick glance. I'll see if I run into any issues while editting.