airflow-dbt-python icon indicating copy to clipboard operation
airflow-dbt-python copied to clipboard

Published 20 hours ago • verified publisher icon tomasfarias

Draft: Update supported versions matrix

Open millin opened this issue 1 year ago • 2 comments

millin avatar Jun 25 '24 13:06 millin

Tried testing locally, but it seems like some new flags need to be supported starting with dbt 1.7, and user_config parameter has been removed from Profile. I managed to get some tests to pass by adding the following flags in utils/config.py:

        flags_dict["PARTIAL_PARSE_FILE_DIFF"] = self.partial_parse_file_diff
        flags_dict["USE_EXPERIMENTAL_PARSER"] = self.use_experimental_parser
        flags_dict["CACHE_SELECTED_ONLY"] = self.cache_selected_only
        flags_dict["PARTIAL_PARSE_FILE_PATH"] = self.partial_parse_file_path

(And also the corresponding class attributes)

As well as dropping user_config=user_config when calling from_raw_profile_info.

Dag tests (tests/dags) are passing, but other tests seem to fail to select any models to run. Something seems to have changed with latter versions of dbt but I haven't figured out what :thinking:

tomasfarias avatar Jun 29 '24 17:06 tomasfarias

Sorry, I created this pr prematurely. I've already fixed most of the bugs locally, but haven't pushed yet. I'll try to finish on Monday.

millin avatar Jun 29 '24 20:06 millin

Sorry, I created this pr prematurely. I've already fixed most of the bugs locally, but haven't pushed yet. I'll try to finish on Monday.

No problem! Happy to review next week and get this released.

tomasfarias avatar Jun 29 '24 23:06 tomasfarias

Will release shortly. Thanks for the great work @millin

tomasfarias avatar Jul 05 '24 09:07 tomasfarias