Tomas Bjerre

Results 366 comments of Tomas Bjerre

I think this is implemented now.

I'm actually regretting adding it as a supported tool. There seems to be many variations of how it prints the findindings in the log. I opened an issue about parsable...

https://github.com/google/error-prone/pull/1132

There is also: #37 Probably best to wait for this one to get merged: https://github.com/google/error-prone/pull/1132 and then rewrite the parser to parse that output.

I'm not really sure how this should be solved. If ErrorProne is giving this output, and the purpose of the ErrorProne parser is to parse that output. Then that is...

Ok, I see. You are right. But the Error Prone parser is fragile. The correct way of fixing this would be to solve: https://github.com/google/error-prone/issues/444 You can up-vote or comment that...

It feels like a bumpy road to go down... Perhaps you can replace it yourself before parsing the output with the lib? https://stackoverflow.com/questions/5410757/delete-lines-in-a-text-file-that-contain-a-specific-string

Sounds good. If so I would need a sample report to use for testning. Or you file a PR. I also replied in you issue at Spotless.

Ok! Should be possible with severity and message being hard coded to something. https://github.com/tomasbjerre/violations-lib/blob/1680f68f4d4381a1eda22ce9ab14c97f2b3daed6/src/main/java/se/bjurr/violations/lib/model/Violation.java#L167 I am parsing a patch in a library using this library. Perhaps it should be moved...

Im putting this on my todo list. If you can supply an example, that qould be great