Tomas Aschan comments

Results 213 comments of


                                            Tomas Aschan

Fix defaultIsZeroValue check for generic Value types

Change LGTM, but it'd be nice to have it covered by tests.

Fix defaultIsZeroValue check for generic Value types

Yes, tests for this go in `flag_test.go`! [Here are the official getting-started docs for testing in Go](https://go.dev/doc/tutorial/add-a-test) in case you need a reference. I imagine you should be able to...

Fix defaultIsZeroValue check for generic Value types

/lgtm

Fix defaultIsZeroValue check for generic Value types

Thank you for your contribution!

Do not reconcile unmanaged ResourceGroups

@fsommar @sdowell What's the status here? Is this already implemented, or is it an up-for-grabs feature to take a stab at? (I've started thinking a little about tech stuff as...

Do not reconcile unmanaged ResourceGroups

A bit of both, I'd say; we don't need the status updates and want to avoid the additional load on the API server from them, and we were also missing...

chore: Run go work sync to update all modules

Huh, build failure is interesting. Do we require different things on master vs in a PR build, somehow? 🤔

KDP Reconciler does not set observedGeneration on the managed resource

I agree this would be useful, and shouldn't be terribly hard to implement. I guess the "hard" part is to determine whether the declarative resource definition has `status.observedGeneration` defined in...

KDP Reconciler does not set observedGeneration on the managed resource

/remove-lifecycle stale

KDP Reconciler does not set observedGeneration on the managed resource

Thinking a bit more about this, it _is_ already possible to do this with the current features of KDP, by utilizing the `BuildStatus` API of the status builder: ```go //...