Tomás Pollak

Results 151 comments of Tomás Pollak

Yikes, totally forgot about this. Looks a-ok! Would you add a quick test to make sure the result we get is the expected one?

@Borewit That's odd. I'll take a look.

Hmm, looks like you're right. I was looking at the [test suite](https://github.com/tomas/needle/blob/master/test/headers_spec.js) regarding the 'Connection' header and found [this](https://github.com/tomas/needle/blob/master/test/headers_spec.js#L134-L135). It's been a while since I looked at the keep-alive behaviour,...

I'm in the middle of something now, but hope to take a look later today.

Good point. Would you submit a PR? :)

Thanks for the PR @Al-Kostryukov. I'll see if I can simplify the use of keep-alive without having to initialize a http agent.

Ok so after diving a bit deeper I think I found out what is going on. Turns out that if you pass one or more of the TLS options (e.g....

Definitely yes. If someone can submit a PR it would be great. Otherwise I can try to look at this during the weekend.

Hi @emamid, I hadn't run into this before. AFAIK we pass the options to Node's `http` module in the same way for both requests. I'll take a look now and...

I just tested and the option is correctly set on both types of request. Are you sending your request to a https endpoint? Are there any redirects or proxies acting...