gpb icon indicating copy to clipboard operation
gpb copied to clipboard

Add licensing information about protobuf-files

Open lemenkov opened this issue 1 year ago • 1 comments

Copied verbatim from upstream.

lemenkov avatar Aug 01 '24 10:08 lemenkov

Thanks, makes sense. I'll include it. Only thing that I find is of concern is the end of the last paragraph, "This code is not standalone and requires a support library to be linked with it. This support library is itself covered by the above license.", which is referring to the Google's protobuf lib, not this gpb where it would now be appearing. I'm thinking to prepend a sentence or two to the entire license text to make clear what this license is covering.

tomas-abrahamsson avatar Aug 07 '24 12:08 tomas-abrahamsson

I just realized that I forgot to include this PR in the release that I just made (4.21.2). Sorry about that and about the rather long delay. I pushed to your branch an added commit to address the concerns in my previous comment. Does it look ok to you? If so, then I'll merge it and make another release.

tomas-abrahamsson avatar Dec 28 '24 18:12 tomas-abrahamsson

LGTM, please merge.

lemenkov avatar Jan 08 '25 15:01 lemenkov

Merged and included in 4.21.3. Thanks for the PR.

tomas-abrahamsson avatar Jan 13 '25 19:01 tomas-abrahamsson