angular-challenges icon indicating copy to clipboard operation
angular-challenges copied to clipboard

Answer 48: Avoid losing form data solution

Open svenson95 opened this issue 10 months ago • 3 comments

  • I used a canDeactivate guard to prevent navigation while the form is dirty - as the challenge hint recommends in a functional way.
  • Furthermore i've added a UnloadGuardDirective, to warn the user before navigate outside the application, like closing the window or navigate to a different page.
  • Changed the dialog attribute role="alert" to role="alertdialog" and added aria-labelledby="alert-title" & aria-describedby="alert-description" to comply W3C conventions. Would love to get some feedback to this topic.

svenson95 avatar Apr 17 '24 08:04 svenson95

Great work, but you can rebase your challenge because of all the change you have made 😅

tomalaforge avatar Apr 19 '24 16:04 tomalaforge

Great work, but you can rebase your challenge because of all the change you have made 😅

I think i did something wrong, now there are 41 files changed. Do you know how to fix this?

svenson95 avatar Apr 23 '24 12:04 svenson95

When you added your other PR, you must have changed the file names and now there is a merge conflict.

Check this Stack Overflow's last answer.

You could also try to avoid all this and try to update the branch with Github that might fix it.

jdegand avatar Apr 25 '24 03:04 jdegand

This pull request is stale because it has been open for 15 days with no activity.

github-actions[bot] avatar May 20 '24 00:05 github-actions[bot]