Answer:1

[chekit]

Checklist for challenge submission

• [x ] Start your PR message with Answer:${challenge_number}

Warning:

• If you want feedback or review, you must support the project on GitHub:
  • $5 per review
  • $25 for lifetime reviews
  • Create one of more challenges
  • Have many valuable contributions to the project

Alternatively, you can still submit your PR to join the list of answered challenges or to be reviewed by a community member. 🔥

[chekit]

Hi @chekit,

thank you so much for your PR. 🙏🏻 This is the first review, I do. So please do not take my comments too serious.

Here are general thoughts about the given goal “. The goal of the challenge is to create a CardComponent that can be customized without any modifications.”

• I think the typing of the list-input of CardComponent would cause an issue, since the typing limits the usage to objects having id, firstname, name.
• Other than that, I think the intention was to make the card reusable by using ngTemplateOutlet
• Nevertheless, you managed to make the card reusable by abstracting the data-model.
• In the end, I think ngTemplateOutlet makes the card more reusable.

Btw: I am not sure if I should approve the PR or not. Not sure about the process, here. :-) //cc @tomalaforge

Cheers from Leipzig, Germany Gregor

Hi @GregOnNet,

Thank you a lot for such a detailed review. It was really nice to practice and recall the concepts which I'm not using everyday. I did some changes and left a comments to your comments.

Once again, much appreciation :)

P.S. I'm not sure you need to approve PR to not override the original exercise

Cheers from Amsterdam, The Netherlands. Anton 😉

[GregOnNet]

@chekit Hey, thanks for the feedback. I really appreciate it.

Yes, I learned, that these PRs are tagged in order to mark them as answer. :-)

[github-actions[bot]]

This pull request is stale because it has been open for 15 days with no activity.

[github-actions[bot]]

This pull request was closed because it has been inactive for 5 days since being marked as stale.