crash-lab icon indicating copy to clipboard operation
crash-lab copied to clipboard

Specify Saboteur Port

Open tddmonkey opened this issue 9 years ago • 3 comments

Hi,

I'm running Saboteur inside Docker and mapping the port to localhost. Looking at the Saboteur Java client it seems the port is hardcoded which will be problematic if I need to run multiple containers with Saboteur.

Is it possible to have it changed so that the port can be specified when creating the Saboteur client?

Thanks.

tddmonkey avatar Apr 18 '16 16:04 tddmonkey

I've pushed 0.3 out with the ability to specify port numbers. Should be on Maven central in a bit.

Please let me know how you get on with it. Haven't touched this code for 2 years and it didn't feel all that familiar.

tomakehurst avatar Apr 19 '16 22:04 tomakehurst

Hey Tom - I know I'm coming back to this a bit late, but did the code changes that went along with this version get merged to master and pushed? I don't see them in the codebase at all. I was looking at bumping some dependency versions and the master branch now breaks my code.

Thanks

tddmonkey avatar Nov 03 '17 16:11 tddmonkey

Hah, looks like I forgot to push the last commit before I released it to m2. Just done that, so it should all be there now.

tomakehurst avatar Nov 07 '17 15:11 tomakehurst