hlua icon indicating copy to clipboard operation
hlua copied to clipboard

Published 20 hours ago • verified publisher icon tomaka

Follow up to #222: fix signatures of luaopen_* functions in hlua

Open fenollp opened this issue 1 year ago • 2 comments

fenollp avatar Jul 27 '24 14:07 fenollp

Ah, I forgot to update the main library, which was definitely wrong. These functions are not documented at all, but looking at their source code they push a table on the stack, so we don't want to just expose them. Instead, they should at least return a PushGuard.

tomaka avatar Jul 27 '24 15:07 tomaka

Oh well, I'm just here to silence some compilation issues. To me it'd be fine if these fns continued to not return anything.

Looking at the code, I'm not confident at all in how I should create these PushGuards :) Maybe you can help?

fenollp avatar Jul 27 '24 16:07 fenollp

Could someone perhaps take a look at this and possibly merge + release it? Without this, we currently can't build libremarkable which prevents us from publishing to crates.io (because depending on git urls is not allowed).

https://haste.cosmos-ink.net/onyxibejiw.vt100

LinusCDE avatar Sep 09 '25 20:09 LinusCDE