recap icon indicating copy to clipboard operation
recap copied to clipboard

Add bundle install retry feature

Open comjf opened this issue 10 years ago • 3 comments

Sometimes the RubyGem service returns a lot of 503s (happened to me today for about 3 hours on different gems) and the deploy:setup phase wipes the whole directory if it fails, making you start from scratch.

I propose a change that allows commands to be rerun if desired. I wrote up a patch but had 2 errors in testing it.

  1. when I do vagrant up I get The box you attempted to add doesn't match the provider you specified.

Provider expected: virtualbox Provider of box: vmware_fusion

  1. rspec seems to have 1 error, but I think it's just a mocking issue. Where does mocka actually store it's mocks so I can modify it?

My commit can be found here: https://github.com/weddingwire/recap/commit/e547f84359d326c88672a9347ad9756807deaf24

Thank you, James Flowers

comjf avatar Nov 11 '13 22:11 comjf

@tomafro Any ideas?

comjf avatar Nov 18 '13 17:11 comjf

I think being able to retry gem installation will be valuable, particularly given how flaky github and rubygems seem to be. Luckily though, we can add it without any (real) code. The latest bundler (pre-release) adds a --retry flag, so once that's been released, I'll add that to the recipe. (see here: https://github.com/bundler/bundler/pull/2601)

As for the vagrant problem, I'm amazed you went to the effort of running the tests - well done! As you've probably figures out though, I wrote them using the vmware fusion adapter for vagrant, not bog-standard vagrant. I'll look into getting them running on both.

tomafro avatar Nov 18 '13 17:11 tomafro

@tomafro is there an update? This has been released a while ago.

comjf avatar Dec 05 '14 02:12 comjf