dicodile icon indicating copy to clipboard operation
dicodile copied to clipboard

ENH accelarate dicodile

Open hndgzkn opened this issue 2 years ago • 1 comments

Improves dicodile's performance:

  • Update signatures of functions adding seg_bounds and seg_inner_bounds to avoid unnecessary calls to Segmentation.get_seg_bounds.
  • Separates worker and local segmentation classes.

hndgzkn avatar Jan 03 '23 12:01 hndgzkn

Codecov Report

Base: 78.29% // Head: 78.60% // Increases project coverage by +0.30% :tada:

Coverage data is based on head (24d414b) compared to base (8e5a75a). Patch coverage: 95.16% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   78.29%   78.60%   +0.30%     
==========================================
  Files          43       43              
  Lines        2856     2888      +32     
==========================================
+ Hits         2236     2270      +34     
+ Misses        620      618       -2     
Flag Coverage Δ
unittests 78.60% <95.16%> (+0.30%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dicodile/update_z/coordinate_descent.py 41.62% <80.00%> (+0.44%) :arrow_up:
dicodile/workers/dicod_worker.py 96.03% <89.36%> (+0.04%) :arrow_up:
dicodile/utils/segmentation.py 96.69% <95.80%> (+0.18%) :arrow_up:
dicodile/update_z/dicod.py 79.25% <100.00%> (+0.22%) :arrow_up:
dicodile/utils/debugs.py 100.00% <100.00%> (ø)
dicodile/utils/tests/test_segmentation.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jan 03 '23 12:01 codecov[bot]