Thomas Moreau

Results 170 comments of Thomas Moreau

I would say each subclass should have its own singleton. But it would be nice to do it in a way where the subclass doesn't need to implement anything. I...

Yes, I agree this is more an issue for `loky` user and opened an ticket joblib/loky#254 to track it. I don't know what you want to do for `joblib`, I...

Thanks for the ping on this feature. To make progress, the best would be to have people testing this feature extensively to see that it does not break. One would...

Thanks for the ping on this feature. To make progress, the best would be to have people testing this feature extensively to see that it does not break. I can...

Yes I agree this is very specific and having too many parameters make it harder to use/maintain so let's not add this as one can simply call `make_correlated`, take abs...

Thanks a lot @cassiofragadantas anyway, sorry to have you made the code for not using it in the end.

I don't think this is correct, what is the difference between standalone and `allow_meta_from_json`? Sorry I feel like I reimplemented a bit the same logic on the meta data (I...

no worries, sorry I did a second implementation instead of merging this one. a follow up PR would be nice yes

#621 introduces a `url` metadata that is used to set the name of the benchmark as the name of the repo. This should improve on renaming, but only when the...

Closing this one in favor of #479