Wax
Wax copied to clipboard
Pedantic warnings show some fixable issues
If you enable pedantic warnings on the WiX candle settings in Votive you get some warning that I think could be fixed.
- Files imported from project dependencies don't have the 'KeyPath' attribute set to 'yes' even though you have a file per component and the file is an assembly or dll with version information in it. Could possibly set this to true if there is only one file per component?
- The GUIDs generated have mixed case. Switching the GUID format to upper case only would fix that simply enough.
Wax.Model\Wix\WixSourceFile.cs
var componentElement = new XElement(WixNames.ComponentNode, new XAttribute("Id", id), new XAttribute("Guid", Guid.NewGuid().ToString("D").ToUpper()));