Easy_xkcd icon indicating copy to clipboard operation
Easy_xkcd copied to clipboard

Explain comic

Open moshpirit opened this issue 9 years ago • 12 comments
trafficstars

Internal view of the explanation instead of a browser requirement.

moshpirit avatar Jun 21 '16 18:06 moshpirit

It uses chrome custom tabs, which has some advantages over an internal solution.

tom-anders avatar Jun 21 '16 20:06 tom-anders

Which ones? I only want to read the explanation text, that's all.

moshpirit avatar Jun 22 '16 11:06 moshpirit

It supports preloading the explanations and is faster than Android's webview. Just displaying the explanation text would involve a lot of html-parsing and would probably be slower.

tom-anders avatar Jun 22 '16 11:06 tom-anders

I think it worth it, it's way more comfortable having the explanation already in the same app. In fact, to me it seems like opening the browser and loading the website may require more time than just loading the text on the app, which could be also done in the background while we're reading the comic, stored in the cache and deleted when we close the app.

moshpirit avatar Jun 22 '16 11:06 moshpirit

I'll do some testing when I have time.

tom-anders avatar Jun 22 '16 12:06 tom-anders

Thanks a lot, peaceful and gentleman T-Rex.

moshpirit avatar Jun 22 '16 12:06 moshpirit

I.e. what I'm asking is a pop-up for the explanation just like we have for transcription.

Again, thanks a lot!

moshpirit avatar Sep 22 '16 22:09 moshpirit

Hello! I don't want to put you in a hurry but I'd like to know how is it going, did the tests go well? :-)

moshpirit avatar Dec 23 '16 15:12 moshpirit

If you could get someone from the NewPipeExtractor team interested they have plenty of experience with web parsing.

PeterHindes avatar Jan 10 '20 17:01 PeterHindes

It should be possible to get the data via the MediaWiki API as JSON, but it's in a Markup language and needs to be parsed first. Sadly, I'm not experienced enough in Kotlin to implement it.

FineFindus avatar Apr 30 '23 20:04 FineFindus