pgsync icon indicating copy to clipboard operation
pgsync copied to clipboard

#remove unused searching for doc_id

Open pigTom opened this issue 3 years ago • 2 comments

Execuse me, I found the code snipped is unuseful and it will cause problem, child id type is diffirent from parent node id. we using fields which is child value to search parent table, the logic is wrong.

 for doc_id in self.es._search(
                        self.index,
                        node.parent.table,
                        fields,
                    ):

fix https://github.com/toluaina/pgsync/issues/352

pigTom avatar Nov 01 '22 05:11 pigTom

Execuse me, I found the code snipped is unuseful and it will cause problem, child id type is diffirent from parent node id. we using fields which is child value to search parent table, the logic is wrong.

 for doc_id in self.es._search(
                        self.index,
                        node.parent.table,
                        fields,
                    ):

fix #352

I think removing this will lead to other problems. I have somewhat addressed this in this commit . So this should be fixed in the main branch

toluaina avatar Nov 13 '22 14:11 toluaina

Can you please confirm if this is resolved now please. I strongly feel this has been fixed in the master. Apologies for the delay

toluaina avatar Dec 13 '22 21:12 toluaina