react-native-google-places icon indicating copy to clipboard operation
react-native-google-places copied to clipboard

Allow initialize google places SDK from javascript

Open GregoryNative opened this issue 6 years ago • 6 comments

I found this feature useful for me. Let me know if I need to add something else here.

GregoryNative avatar Oct 17 '19 19:10 GregoryNative

There are should be added some notes as it will brake Android after migration

GregoryNative avatar Oct 17 '19 19:10 GregoryNative

This is a great improvement. It should really be merged onto master at some point.

rauchp avatar Jan 20 '20 02:01 rauchp

Hi @GregoryNative, this looks interesting, I have thought about this route too. I am sorry I have been away and just looking at this. I am working on releasing a v4, a week from now, at the latest. However, do you think the keys would be more secure in Js? Feel feel to chime in again with your replies to this though. Thank you for your contributions all the same.

tolu360 avatar Jun 15 '20 14:06 tolu360

Hi, @tolu360 that's fine as we have react-native-config to use with.

GregoryNative avatar Jun 15 '20 14:06 GregoryNative

So @GregoryNative have you had any issues with your keys in Manifest files? I am leaning towards going with you as some users have reported Google Play Store flagging the current location in Gradle properties as less secure as well.

tolu360 avatar Jun 15 '20 16:06 tolu360

As far as I know it's fine. I am not on project with usage of this lib anymore. But as least several months ago there were no issues @tolu360

GregoryNative avatar Jun 20 '20 17:06 GregoryNative